Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3894: Downgrade Typescript to 5.4.x #5028

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

jwhitlock
Copy link
Member

We're getting an error in CircleCI, and @groovecoder can reproduce locally:

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.5.0

YOUR TYPESCRIPT VERSION: 5.5.4

Please only submit bug reports when using the officially supported version.

This PR:

  1. Removes the override section from frontend/packages.json, since overrides only work in the root package.json ([DOCS] Please document "The overrides key will only be considered when it is in the root package.json file for a project" npm/cli#4517).
  2. Add an override for typescript 5.4.5, the latest in the 5.4.x series
  3. Uninstall and re-install packages to get them all on typescript 5.4.5,
  4. Fix the return type of formatRangeToParts to get typescript passing

How to test:

  1. Run npm install
  2. Run npm list typescript. All versions should be 5.4.5. If not, you may need to remove node_modules and frontend/node_modules, then start over at step 1
  3. In the frontend folder, run npm run build to build the frontend. There should be no errors.
  4. Still in the frontend folder, run npm run lint to lint the frontend. There should be no warnings.

@groovecoder groovecoder added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 8bf612b Sep 12, 2024
29 checks passed
@groovecoder groovecoder deleted the typescript-5.4.x-mpp-3894 branch September 12, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants