MPP-3831: Send metrics_event data to influxdb, logs instead of UA #5108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The send_ga_ping code is sending data to the deprecated Universal Analytics endpoint, which drops the data. Instead, send the core data as a tagged counter metric, and as a log message. The log includes a truncated hash of the GA UUID, to allow estimation of unique users. The metric does not include the GA UUID, to avoid high-cardinality issues.
groovecoder
approved these changes
Oct 15, 2024
| @@ -19,7 +19,6 @@ dockerflow==2024.4.2 | |||
| drf-spectacular==0.27.2 | |||
| drf-spectacular-sidecar==2024.7.1 | |||
| glean_parser==15.0.1 | |||
| google-measurement-protocol==1.1.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MPP-3831, send the
/metrics-eventdata to InfluxDB (tagged counter metric) and logs instead of Universal Analytics, which was retired July 1, 2024. The metric isfx.private.relay.metrics_event, and has the UA data as tags. The info-level log has the messagemetrics_event, with the UA data as extra JSON-encoded data. The log includes a truncated hash of the UUID4 generated by the extension, so that we can continue to estimate active installations. We could just log the UUID4 as well, but this ensures we can't easily go from logs to an extension.I removed the thread code that was talking to Universal Analytics. Since we're talking to in-cluster services instead of a remote service, the data collection should be fast again. It was a cool hack.