Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3901: update content for disable-mask email #5109

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

groovecoder
Copy link
Member

@groovecoder groovecoder commented Oct 15, 2024

This PR fixes #MPP-3901.

image

How to test:

  1. Go to http://127.0.0.1:8000/emails/disabled_mask_for_spam_test and http://127.0.0.1:8000/emails/disabled_mask_for_spam_test?content-type=text/plain
  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug.
  • I've added or updated relevant docs in the docs/ directory.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@groovecoder groovecoder force-pushed the mpp-3901-update-spam-email-notification-content branch 2 times, most recently from 17efb2f to 23bed70 Compare October 15, 2024 16:23
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @groovecoder, looks good!

</style>
<table role="presentation" border="0" cellpadding="0" cellspacing="10px" style="padding: 30px;" align="center">
{% with mask|striptags|urlencode as mask_for_url %}
{% with "/accounts/profile/#"|add:mask_for_url as mask_url%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice job constructing this string

@groovecoder groovecoder force-pushed the mpp-3901-update-spam-email-notification-content branch from 23bed70 to c6cbb10 Compare October 15, 2024 20:26
@groovecoder
Copy link
Member Author

Rebased.

@groovecoder groovecoder added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 94e220e Oct 16, 2024
30 checks passed
@groovecoder groovecoder deleted the mpp-3901-update-spam-email-notification-content branch October 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants