Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPP-3901: update disabled mask email content #5156

Merged
merged 1 commit into from
Oct 30, 2024
Merged

MPP-3901: update disabled mask email content #5156

merged 1 commit into from
Oct 30, 2024

Conversation

groovecoder
Copy link
Member

@groovecoder groovecoder commented Oct 29, 2024 •
edited by jwhitlock
Loading

This PR fixes MPP-3901.

How to test:

  1. Open https://www.figma.com/design/5n1LkFnQrgyykS0hqBBMXZ/Relay-email-updates?node-id=7191-1179&node-type=instance&t=gEqKzYCBNFE1mwHK-0 for the reference text
  2. Open http://127.0.0.1:8000/emails/disabled_mask_for_spam_test?content-type=text/plain
  3. Open http://127.0.0.1:8000/emails/disabled_mask_for_spam_test
    • Verify the text in the email tests matches the figma
  • l10n changes have been submitted to the l10n repository, if any.
  • I've added a unit test to test for potential regressions of this bug.
  • All UI revisions follow the coding standards, and use Protocol tokens where applicable (see /frontend/src/styles/tokens.scss).
  • Commits in this PR are minimal and have descriptive commit messages.

@groovecoder groovecoder force-pushed the update-content-for-disabled-mask-email-mpp-3901 branch 3 times, most recently from 0a43b2b to 614af15 Compare October 29, 2024 19:38
@groovecoder groovecoder requested a review from jwhitlock October 29, 2024 19:42
jwhitlock
jwhitlock requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jwhitlock jwhitlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The invisible content is not loaded because of the string id. But why is there invisible content in the first place???

emails/tests/fixtures/disabled_mask_for_spam_expected.email Outdated Show resolved Hide resolved
emails/templates/emails/disabled_mask_for_spam.html Outdated Show resolved Hide resolved
emails/templates/emails/direct_email_header.html
@@ -159,7 +159,11 @@
}
}
</style>

{% if pretext_ftlmsg_id %}
<div style="display:none !important; color: #ffffff; font-size: 0px; line-height: 0; max-height: 0px; max-width: 0px; opacity: 0; overflow: hidden; mso-hide: all;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of this section?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To implement "preheader text" as shown in the figma. I had to look it up too: https://www.activecampaign.com/blog/email-preheader

@groovecoder groovecoder force-pushed the update-content-for-disabled-mask-email-mpp-3901 branch from 614af15 to 40ee038 Compare October 30, 2024 12:41
@groovecoder groovecoder force-pushed the update-content-for-disabled-mask-email-mpp-3901 branch from 40ee038 to a62a244 Compare October 30, 2024 12:45
@groovecoder
Copy link
Member Author

Updated to fix the missing pretext header content.

@jwhitlock jwhitlock added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit cd11727 Oct 30, 2024
30 checks passed
@jwhitlock jwhitlock deleted the update-content-for-disabled-mask-email-mpp-3901 branch October 30, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhitlock jwhitlock jwhitlock approved these changes

Assignees

@groovecoder groovecoder

@jwhitlock jwhitlock

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@groovecoder @jwhitlock