Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3487: Update to Python 3.11.10, prepare for Python 3.12, 3.13 #5167

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

jwhitlock
Copy link
Member

DRAFT

Prepare for the next round of Python updates.

@jwhitlock jwhitlock marked this pull request as draft November 1, 2024 16:47
@jwhitlock jwhitlock marked this pull request as ready for review November 1, 2024 17:27
@jwhitlock jwhitlock requested a review from groovecoder November 1, 2024 17:30
Comment on lines 683 to +687
name: python 3.12 test
python_version: "3.12"
python_version: "3.12.7"
command: pytest
pytest_fail_fast: true
test_results_filename: pytest-python-3-12.xml
filters: *default_filters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (non-blocking): Should we alphabetize these? Or at least make their order consistent in each python job?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm ordering the python_job job definition, then ordering the workflow definitions:

  • python_job.executor parameters
    • name
    • postgres_version (as a matrix for the postgres jobs)
    • python_version
    • variant
  • python_job parameters
    • allow_fail
    • command
    • executor
    • mypy_strict
    • production_with_new_migrations
    • pytest_fail_fast
    • pytest_phones_backend
    • test_results_filename
    • update_dependency
  • workflow parameters
    • filters
    • (matrix could go here since it is a workflow parameter)

Sort params by:
* python_job.executor parameters, alpha sorted
* python_job parameters, alpha sorted
* filters
@jwhitlock jwhitlock enabled auto-merge November 4, 2024 16:00
@jwhitlock jwhitlock added this pull request to the merge queue Nov 4, 2024
jwhitlock added a commit that referenced this pull request Nov 4, 2024


MPP-3487: Update to Python 3.11.10, prepare for Python 3.12, 3.13
Merged via the queue into main with commit 8fd4a53 Nov 4, 2024
30 checks passed
@jwhitlock jwhitlock deleted the python-3-12-require-tests-mpp-3487 branch November 4, 2024 16:15
@jwhitlock jwhitlock mentioned this pull request Nov 8, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants