Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPP-3942: Fix log_group_id in developer_mode log #5175

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

jwhitlock
Copy link
Member

This PR ensures the log_group_id in the developer_mode logs is a string instead of a UUID.

Currently, it looks like this in the logs:

"log_group_id": "UUID('97e53c11-6819-41e2-982b-361ce200e177')"

After this PR, it looks like this:

"log_group_id": "97e53c11-6819-41e2-982b-361ce200e177"

How to test:

  • I've added a unit test to test for potential regressions of this bug.

@groovecoder groovecoder added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@groovecoder groovecoder added this pull request to the merge queue Nov 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2024
@jwhitlock jwhitlock force-pushed the fix-log-group-id-mpp-3932 branch from 4cce5ce to 8bf7c57 Compare November 7, 2024 16:27
@jwhitlock jwhitlock enabled auto-merge November 7, 2024 16:27
@jwhitlock jwhitlock added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit bd7b824 Nov 7, 2024
30 checks passed
@jwhitlock jwhitlock deleted the fix-log-group-id-mpp-3932 branch November 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants