Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #898 - Update VPN promo banner copy #912

Merged
merged 5 commits into from
Jul 13, 2021
Merged

Fix #898 - Update VPN promo banner copy #912

merged 5 commits into from
Jul 13, 2021

Conversation

maxxcrawford
Copy link
Contributor

@maxxcrawford maxxcrawford commented Jul 9, 2021 •
edited
Loading

⚠️ NOTE: DO NOT MERGE/DEPLOY UNTIL TUESDAY, JULY 13TH ⚠️

This PR removes the current pricing promo from the VPN banner. The new strings match what is also on Monitor.

Note that because this app is not currently localized, this promo will appear to ALL USERS, only in English.

Preview:
image

Testing

  • Clear any previous cookies for mozgcp.net if you have tested this this banner previously)
  • Go to homepage (https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/)
  • Expected: See VPN banner at top of the page with the following text:
    • Headline: Now’s the time to boost your safety online.
    • Body copy: Mozilla’s Virtual Private Network helps shield your internet connection from hackers and spies.

@maxxcrawford maxxcrawford added the 🛑 Do Not Merge Do not merge this PR, even if approved. label Jul 9, 2021
@maxxcrawford
Copy link
Contributor Author

cc/ @tcinotto

@maxxcrawford maxxcrawford linked an issue Jul 9, 2021 that may be closed by this pull request
Remove Mozilla VPN intro pricing banner on Relay: JULY 13th #898
Closed
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay July 12, 2021 18:26 Inactive
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay July 12, 2021 18:28 Inactive
@maxxcrawford maxxcrawford force-pushed the 898-vpn-promo-update branch from d628592 to 821af70 Compare July 12, 2021 18:35
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay July 12, 2021 20:33 Inactive
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay July 12, 2021 20:35 Inactive
@maxxcrawford maxxcrawford temporarily deployed to fx-private-relay July 12, 2021 23:02 Inactive
@maxxcrawford maxxcrawford marked this pull request as ready for review July 12, 2021 23:04
@maxxcrawford
Copy link
Contributor Author

@lesleyjanenorton Use this URL to test (if you don't wanna run it locally): https://dev.fxprivaterelay.nonprod.cloudops.mozgcp.net/

lesleyjanenorton
lesleyjanenorton approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@lesleyjanenorton lesleyjanenorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the link! Looks great - only noticed one thing and it's the tiniest of nits: .vpn-promo-banner button (only the close button though) has the faintest background color and would probably benefit frombackground: transparent;.
Screen Shot 2021-07-12 at 7 36 44 PM

@maxxcrawford
Copy link
Contributor Author

@lesleyjanenorton Ahh! Great catch. Fixed!

@maxxcrawford maxxcrawford force-pushed the 898-vpn-promo-update branch from 28f7420 to 965eb1a Compare July 13, 2021 04:29
@maxxcrawford maxxcrawford merged commit c233832 into main Jul 13, 2021
@maxxcrawford maxxcrawford deleted the 898-vpn-promo-update branch August 3, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesleyjanenorton lesleyjanenorton lesleyjanenorton approved these changes

Assignees
No one assigned
Labels
🛑 Do Not Merge Do not merge this PR, even if approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Mozilla VPN intro pricing banner on Relay: JULY 13th
2 participants
@maxxcrawford @lesleyjanenorton