Fix #803 - Exit out of survey banner #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Design query: Is it just me or are those buttons a little too close to the survey question? Should adding small design tweaks be made in a PR addressing a different/specific issue? What is the recommended practice for that? |
maxxcrawford
requested changes
Jul 26, 2021
codemist
commented
Jul 26, 2021
maxxcrawford
requested changes
Jul 27, 2021
maxxcrawford
requested changes
Jul 28, 2021
static/scss/partials/main.scss
Outdated
| .micro-survey-banner.hidden { | ||
| display: none; | ||
| .micro-survey-banner.is-hidden { | ||
| display: none !important; |
There was a problem hiding this comment.
Is the !important here necessary?
maxxcrawford
requested changes
Aug 3, 2021
static/js/app.js
Outdated
|
|
||
| //Micro Survey Banner | ||
| function dismissSurvey() { | ||
| var survey_banner = document.getElementById("micro-survey-banner"); |
There was a problem hiding this comment.
We should use const (and let) instead of var.
Suggested change
| var survey_banner = document.getElementById("micro-survey-banner"); | |
| const survey_banner = document.getElementById("micro-survey-banner"); |
There was a problem hiding this comment.
Done! Ques: why do we use const over var?
There was a problem hiding this comment.
It's a convention from ES6. The constvalue can't be changed through reassignment, and it can't be redeclared. Since it cannot be reassigned, you have less scenarios, side effects or edge cases to consider.
maxxcrawford
approved these changes
Aug 3, 2021
maxxcrawford
requested changes
Aug 3, 2021
codemist
commented
Aug 5, 2021
maxxcrawford
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview:
https://user-images.githubusercontent.com/13066134/126832640-71876738-04c1-437d-82f8-786a95a4570c.mov