Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #958 - Add focus effect to avatar icon #983

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

codemist
Copy link
Collaborator

@codemist codemist commented Jul 30, 2021

Pressing tab now shows the :focus effect for the avatar icon, and remains when selected.

Demo/Preview:

Screen.Recording.2021-07-30.at.12.08.48.PM.mov

@codemist codemist requested a review from maxxcrawford July 30, 2021 19:11
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

static/scss/partials/glocal-menu.scss Outdated Show resolved Hide resolved
@codemist codemist requested a review from maxxcrawford August 3, 2021 18:38
Copy link
Contributor

@maxxcrawford maxxcrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the merge conflicts? (The big PR #962 merged, breaking all PRs with CSS commits)

@maxxcrawford maxxcrawford merged commit f0ccc09 into main Aug 3, 2021
@maxxcrawford maxxcrawford deleted the focus-effect branch August 3, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants