Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strings to approved copy #992

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Update strings to approved copy #992

merged 5 commits into from
Aug 5, 2021

Conversation

maxxcrawford
Copy link
Contributor

@maxxcrawford maxxcrawford commented Aug 4, 2021 •
edited
Loading

This PR updates strings to approve copy from the Figma spec.

@maxxcrawford maxxcrawford added 🚧 WIP Work in Progress blocked Issue is blocked from proceeding labels Aug 4, 2021
@maxxcrawford maxxcrawford removed 🚧 WIP Work in Progress blocked Issue is blocked from proceeding labels Aug 5, 2021
@maxxcrawford maxxcrawford marked this pull request as ready for review August 5, 2021 18:52
@maxxcrawford maxxcrawford requested a review from codemist August 5, 2021 18:53
codemist
codemist approved these changes Aug 5, 2021
View reviewed changes
Copy link
Collaborator

@codemist codemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm also not sure if my comment is the right way of saying it...

@maxxcrawford maxxcrawford merged commit 1d7fc28 into main Aug 5, 2021
@maxxcrawford maxxcrawford deleted the new-strings branch August 5, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codemist codemist codemist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxxcrawford @codemist