fix oauth webchannel tests

mozilla · Jun 28, 2023 · 3603292 · 3603292
1 parent 1b01efd
commit 3603292
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/functional-tests/pages/login.ts b/packages/functional-tests/pages/login.ts
@@ -386,8 +386,10 @@ export class LoginPage extends BaseLayout {
     return this.page.locator(selectors.SUBMIT).click();
   }
 
-  async isCWTSEngineHeader() {
-    return this.page.locator(selectors.CWTS_ENGINE_HEADER).isVisible();
+  async waitForCWTSEngineHeader() {
+    await this.page.waitForSelector(selectors.CWTS_ENGINE_HEADER, {
+      timeout: 2000,
+    });
   }
 
   async isCWTSPageHeader() {

diff --git a/packages/functional-tests/tests/oauth/webchannel.spec.ts b/packages/functional-tests/tests/oauth/webchannel.spec.ts
@@ -34,7 +34,7 @@ test.describe('oauth webchannel', () => {
     await login.submit();
 
     // the CWTS form is on the same signup page
-    expect(await login.isCWTSEngineHeader()).toBe(true);
+    await login.waitForCWTSEngineHeader();
     expect(await login.isCWTSEngineBookmarks()).toBe(true);
     expect(await login.isCWTSEngineHistory()).toBe(true);
 

diff --git a/packages/functional-tests/tests/syncV3/signUpWithCWTS.spec.ts b/packages/functional-tests/tests/syncV3/signUpWithCWTS.spec.ts
@@ -63,7 +63,7 @@ test.describe('Sync v3 sign up and CWTS', () => {
     await login.setAge('21');
 
     // The CWTS form is on the same signup page
-    expect(await login.isCWTSEngineHeader()).toBe(true);
+    await login.waitForCWTSEngineHeader();
     expect(await login.isCWTSEngineBookmarks()).toBe(true);
     expect(await login.isCWTSEngineHistory()).toBe(true);
     expect(await login.isCWTSEnginePassword()).toBe(true);