Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(functional-tests): Fix default domain for subscriptions on stage #15374

Merged
merged 1 commit into from
May 24, 2023

Conversation

dschom
Copy link
Contributor

@dschom dschom commented May 24, 2023

Because

  • We had the wrong default domain for subscriptions APIs

This pull request

  • Points at the correct domain (a gcp domain)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Other information (Optional)

This caused problems in the 1.259.0 deployment.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
GeopJr Evan Paterakis
Because:
- We had the wrong default domain for subscriptions apis

This Commit:
- Points at the correct domain (a gcp domain)
@dschom dschom requested a review from a team as a code owner May 24, 2023 18:50
@ashrivastava-qa
Copy link
Contributor

Thanks @dschom for fixing this.

@dschom dschom merged commit bfb1f81 into main May 24, 2023
@dschom dschom deleted the fix-payments-default-smoke-test-url branch May 24, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants