Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(content): Make csp-report.blocked-uri validation check less strict #15385

Merged
merged 1 commit into from
Jun 6, 2023
Merged

task(content): Make csp-report.blocked-uri validation check less strict #15385

merged 1 commit into from
Jun 6, 2023

Conversation

dschom
Copy link
Contributor

@dschom dschom commented May 26, 2023 •
edited
Loading

Because

  • We were generating a lot of error on this validation check
  • This value is only used in a report, so the URI requirement isn't mandatory

This pull request

  • Removes the requirement that the string posted is a valid URL

Issue that this pull request solves

Closes: FXA-7556

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@dschom dschom requested a review from a team as a code owner May 26, 2023 16:37
@dschom dschom requested a review from chenba May 26, 2023 16:37
@dschom
task(content): Make csp-report.blocked-uri validation check less strict
07713b6 
Because:
- We were generating a lot of error on this validation check
- This value is only used in a report, so the uri requirement is mandatory

This Commit:
- Removes the requirement that the string posted is a valid URL
@dschom dschom force-pushed the make-csp-uri-check-less-strict branch from 7bbc4da to 07713b6 Compare May 26, 2023 17:08
@dschom dschom merged commit 8b1b99c into main Jun 6, 2023
@dschom dschom deleted the make-csp-uri-check-less-strict branch June 6, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenba chenba chenba approved these changes

@clouserw clouserw clouserw approved these changes

Assignees

@chenba chenba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dschom @clouserw @chenba