fix(react): Hide loading spinner on CompleteResetPassword only when checks complete #15386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks complete Because: * Users with a recovery key see a flash of CompleteResetPassword before being redirected to AccountRecoveryConfirmKey This commit: * Adjusts the loading spinner state to only hide when recovery key checks have completed Fixes FXA-7170
vpomerleau
approved these changes
May 29, 2023
There was a problem hiding this comment.
LGTM! This works to prevent a flash of the CompleteResetPassword page before redirection.
Just noting that there is still a side issue of the "Reset password with account recovery key" loading even when a link is expired - this will be covered in FXA-7149.
Also spotted some console warnings about ModelValidationErrors and code that causes React state updates should be wrapped into act when the tests are run. I think those were pre-existing though and could be addressed in FXA-7149 too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Fixes FXA-7170
See ticket for before.
Here's with this patch, hitting it twice (since it's fast) and then clicking "Don't have a an account recovery key?":
I also tested with an expired link and without a recovery key.
I tried using
account.loadinghere because we have awithLoadingStatuson the account model and are usingaccount.loadingin just a couple of other places but there's something weird about it, it seems to load two inputs like it’s showing the complete reset PW screen without text; didn't dig further since we have plans to refactor some of this anyway.