Delete pairing-architecture.md #15400
Merged
+0
−358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This in on ecosystem docs now: https://mozilla.github.io/ecosystem-platform/explanation/pairing-flow-architecture I'm opening this PR via the web UI. Let's see how this goes.
pdehaan
reviewed
Jun 1, 2023
Comment on lines
-21
to
-25
|  | ||
|
|
||
| --- | ||
|
|
||
|  |
There was a problem hiding this comment.
nit: Do we need to delete these images as well?
Not sure if any of the current images/* files are used or if they're all orphaned:
git ls-files packages/fxa-content-server/docs/images
packages/fxa-content-server/docs/images/choose_what_to_sync.png
packages/fxa-content-server/docs/images/complete_signin.png
packages/fxa-content-server/docs/images/complete_signin_link_expired.png
packages/fxa-content-server/docs/images/confirm.png
packages/fxa-content-server/docs/images/confirm_signin.png
packages/fxa-content-server/docs/images/pairing-flow1.png
packages/fxa-content-server/docs/images/pairing-flow2.png
packages/fxa-content-server/docs/images/signin.png
packages/fxa-content-server/docs/images/verify_email.pngBut I don't see any .png references in the current docs:
git grep -n "\.png" packages/fxa-content-server/docs/ | wc -l # 0There was a problem hiding this comment.
yeah, we should delete these. I'm not sure about the others. My goal is to migrate all the docs in this directory so it'll get cleaned up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request