Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payments): on upgrade next invoice date fix #15407

Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(payments): on upgrade next invoice date fix #15407

merged 1 commit into from
Jun 7, 2023

Conversation

StaberindeZA
Copy link
Contributor

Because

  • Upgrades where the interval and interval count do not change, the next invoice date is taken from the invoice preview.

This pull request

  • Fixes the invoice date for scenarioes where interval and interval count do not change, by using the date of the current subscription.

Issue that this pull request solves

Closes: #FXA-7060

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@StaberindeZA
fix(payments): on upgrade next invoice date fix
45b5864 
Because:
- Upgrades where the interval and interval count do not change, the
  next invoice date is taken from the invoice preview.

This Commit:
- Fixes the invoice date for scenarioes where interval and interval
  count do not change, by using the date of the current subscription.

Closes FXA-7060
@StaberindeZA StaberindeZA requested a review from a team as a code owner June 2, 2023 20:10
@xlisachan xlisachan self-assigned this Jun 6, 2023
xlisachan
xlisachan approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unable to duplicate the bug; however, LGTM! Thanks for updating and adding tests!!

@StaberindeZA StaberindeZA merged commit ec43d4a into main Jun 7, 2023
@StaberindeZA StaberindeZA deleted the fxa-7060-next-invoice-fix branch June 7, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees

@xlisachan xlisachan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StaberindeZA @xlisachan