Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Delete packages/fxa-content-server/docs directory #15414

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

clouserw
Copy link
Member

@clouserw clouserw commented Jun 6, 2023

Because

  • This all exists in the ecosystem docs.

Shane wrote an updated version of the architecture doc: https://mozilla.github.io/ecosystem-platform/explanation/content-server-architecture
And I moved query parameters: https://mozilla.github.io/ecosystem-platform/relying-parties/reference/query-parameters

This pull request

  • Removes the old docs

@clouserw clouserw requested a review from a team as a code owner June 6, 2023 16:10
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Current as of Nov 17th, 2022 accurate at the top of the new query param page?

Thanks for transferring!

@clouserw
Copy link
Member Author

clouserw commented Jun 6, 2023

I put that on there because it was the last date the page was updated on github. Honestly, I'd like to review some of those params. disable_local_storage ? automatedBrowser ? why would we have these things?

@clouserw clouserw merged commit ca6ff51 into main Jun 6, 2023
@clouserw clouserw deleted the clouserw-patch-2 branch June 6, 2023 16:57
@LZoog
Copy link
Contributor

LZoog commented Jun 6, 2023

@clouserw we do have disable_local_storage for testing purposes (unit and functional), if you search the codebase you'll see a couple comment scattered about. I don't think we need automatedBrowser with Playwright though. We'll definitely have these all double checked by the end of the React project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants