fix(third-party-auth): Don't show Google/Apple login buttons in the Sync flow #15443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ync flow Because: * Users have to have an FxA account to register/login to Sync so we should not allow them to login with third-party auth in this flow This commit: * Hides these buttons if the flow is Sync Fixes FXA-7655
|
Tried this out locally with a fresh profile. Looks good with the test link, but if I remove |
Yes, you'll still be in the sync flow because of that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Fixes FXA-7655
Test locally @ here before and after patch. Looked better to me to leave the "firefox family" text when third party auth buttons are hidden - there's a nicer way to do this in Backbone/Mustache than have two sets of
#firefox-family-servicesreferences in the mustache file (like setting ashouldShowThirdPartyAuthmethod) but we're refactoring this all soon enough so 🤷♀️ as-is seems fine to me.