fix(l10n): Clarify recovery key hint explanation for l10n #15444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: * Previous sentence included two "it"s that could confuse localizers. * We want to ensure that messages are clear for localizers. This commit: * Update string and add comment Closes #FXA-7724
bcolsson
approved these changes
Jun 13, 2023
LZoog
approved these changes
Jun 13, 2023
| @@ -6,7 +6,8 @@ | |||
| # "key" here refers to the "account recovery key" | |||
| flow-recovery-key-hint-header-v2 = Add a hint to help find your key | |||
| # This message explains why saving a storage hint can be helpful. The account recovery key could be "stored" in a physical (e.g., printed) or virtual location (e.g., in a device folder or in the cloud). | |||
| flow-recovery-key-hint-message-v2 = This hint should help you remember where you stored your account recovery key. We’ll show it to you when you use it to recover your data. | |||
| # "it" here refers to the storage hint, NOT the "account recovery key" | |||
| flow-recovery-key-hint-message-v3 = This hint should help you remember where you stored your account recovery key. We can show it to you during the password reset to recover your data. | |||
There was a problem hiding this comment.
Was this new copy approved by Vesta / Design? Not sure if she would prefer "We'll show it" (or "we will") instead of "We can show it".
There was a problem hiding this comment.
Or "We can show this hint to you during…" and avoid using "it" completely.
There was a problem hiding this comment.
Reverting to this string with "it" was suggested by Bryan, and reviewed and approved by Melissa (CX). Less repetitive than having "this hint" in two successive sentences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-7724
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.