fix(payments): on sub confirm show invoice date #15473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
force-pushed
the
fxa-5805-sub-confirm-date
branch
from
00d3b4c to
d95e405
Compare
bcolsson
approved these changes
Jun 23, 2023
sardesam
suggested changes
Jun 23, 2023
There was a problem hiding this comment.
Changes look good to me. One nit.
However, before approving, could we get an explicit confirmation from @stefopsal @chelsea-lewis @marniepw that omitting the details is fine and poses no potential issues (legally, etc.)?
packages/fxa-payments-server/src/components/PaymentConfirmation/index.stories.tsx
Outdated
Show resolved
Hide resolved
|
@sardesam I'm good with this change from my side. |
|
@StaberindeZA @sardesam I'm good with this as well, seems an appropriate move. Thanks for picking this up and adding to the improvements here! |
|
Looks good to me. Thank you!
On Fri, Jun 23, 2023 at 5:08 PM Chelsea Lewis ***@***.***> wrote:
@StaberindeZA <https://github.com/StaberindeZA> @sardesam
<https://github.com/sardesam> I'm good with this as well, seems an
appropriate move. Thanks for picking this up and adding to the improvements
here!
—
Reply to this email directly, view it on GitHub
<#15473 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5UFTJIYFH7D6N26B4GWDIDXMYAT7ANCNFSM6AAAAAAZR4YN64>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
…________________________________
Stefan Opsal
Product Manager, Subscription Platform | Moz://a
|
sardesam
approved these changes
Jun 23, 2023
Because: * The subscription confirmation page shows the current date instead of the latest invoice date. This commit: * Shows the latest invoice date * Does not show the Order details section if invoice number and date could not be found Closes FXA-5805
StaberindeZA
force-pushed
the
fxa-5805-sub-confirm-date
branch
from
d95e405 to
e7e2cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-5805
Checklist
Put an
xin the boxes that applyAdditional information
Note that with this change, if Invoice Number or Invoice Date could not be retrieved, the "Order details" section is hidden. Happy to discuss this some more if there's an alternate more preferred approach.