Emit account event for Pocket Apple user migration #15477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
approved these changes
Jun 26, 2023
| @@ -11,6 +11,10 @@ export const PROFILE_EVENT_ID = | |||
| export const SUBSCRIPTION_STATE_EVENT_ID = | |||
| 'https://schemas.accounts.firefox.com/event/subscription-state-change'; | |||
|
|
|||
| export const APPLE_USER_MIGRATION_ID = | |||
There was a problem hiding this comment.
Is there supposed to be something at this URL? I am guessing this okay, since there's no doc at the schema URL above either.
| await (service as any).handleMessage(msg); | ||
|
|
||
| // topic prefix is undefined and clientId is always Pocket | ||
| const topicName = 'undefined749818d3f2e7857f'; |
There was a problem hiding this comment.
Why is the topic prefix undefined? Shouldn't the value just come from the config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-7666
Checklist
Other information (Optional)
@dschom Tagging you for review on this since you reviewed the original script. I wasn't able to verify the SQS message, but I was able to test that the event gets emitted properly with the Pocket clientId.
Event broker log when running the script