feat(newsletters): Update newsletter checkbox labels, add new newsletter checkbox w/two slugs #15482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZoog
commented
Jun 27, 2023
| slug: 'take-action-for-the-internet', | ||
| }, | ||
| ONLINE_SAFETY: { | ||
| label: t('Be safer and smarter online'), | ||
| slug: 'knowledge-is-power', | ||
| }, | ||
| }; | ||
|
|
||
| export const newsletterNewCopy = { |
There was a problem hiding this comment.
I removed this since it wasn't being used anywhere.
I was thinking of removing other unused newsletters like ONLINE_SAFETY and FIREFOX_ACCOUNTS_JOURNEY and updating auth-server's validity check for only these 3, happy to do that; I'd left them as-is since this way we've got a pool of available/valid newsletters and then we pull in the ones we want on the page 🤷♀️
…ter checkbox w/two slugs Because: * We want to update the label text for two existing newsletters and add a new option to subscribe users to two new newsletter from one new checkbox This commit: * Updates labels per ticket * Adds new checkbox with array of slugs for new newsletter option, does not HTML escape label due to ampersand * Updates server validity check, tests Closes FXA-7527
flodolo
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Closes FXA-7527