Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): revise acknowledgement copy on upgrades #15488

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

sardesam
Copy link
Contributor

@sardesam sardesam commented Jun 29, 2023

Because

  • Now that we are immediately invoicing on upgrades regardless of billing cycle, we want to revise copy throughout the checkout and email process to improve UX and be clear on payment dates and amounts.

This pull request

  • Revises the acknowledgement copy on upgrades.
  • Shows updated copy when useStripeImmediatelyInvoice flag is set to true.
  • Updates tests and stories when aforementioned flag is set to true, where applicable.

Issue that this pull request solves

Closes: FXA-7399

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@sardesam sardesam requested review from a team as code owners June 29, 2023 18:22
@sardesam sardesam force-pushed the FXA-7399 branch 2 times, most recently from cd47b2e to 0d3d340 Compare June 30, 2023 23:37
@sardesam sardesam changed the title [WIP]feat(payments): revise acknowledgement copy on upgrades feat(payments): revise acknowledgement copy on upgrades Jun 30, 2023
Because:

* Now that we are immediately invoicing on upgrades regardless of billing cycle, we want to revise copy throughout the checkout and email process to improve UX and be clear on payment dates and amounts.

This commit:

* Revises the acknowledgement copy on upgrades.
* Uses the stripeImmediatelyInvoice flag to show updated copy.
* Updates tests and stories when aforementioned flag is set to true, where applicable.

Closes FXA-7399
@sardesam sardesam merged commit ece751c into main Jul 4, 2023
@sardesam sardesam deleted the FXA-7399 branch July 4, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants