Fix off-by-zero error in table pagination (#2822)

mozilla · May 15, 2024 · 83a22ab · 83a22ab
1 parent 68b024c
commit 83a22ab
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/controls/Pagination.svelte b/src/components/controls/Pagination.svelte
@@ -39,7 +39,7 @@
     <Button
       tooltip="move back a page"
       on:click={() =>
-        currentPage === 1 ? undefined : changePage(currentPage - 1)}
+        currentPage === 0 ? undefined : changePage(currentPage - 1)}
       level="medium"
       compact
     >
@@ -55,7 +55,7 @@
     </Button>
   </ButtonGroup>
   page
-  {currentPage < 9 ? '0' : ''}{currentPage}
+  {currentPage < 9 ? '0' : ''}{Number(currentPage) + 1}
   of
   {totalPages < 9 ? '0' : ''}{totalPages}
 </div>
diff --git a/src/components/table/TableView.svelte b/src/components/table/TableView.svelte
@@ -85,7 +85,7 @@
     <Pagination
       on:page={(evt) => {
         currentPage = evt.detail.page;
-        store.setField('currentPage', currentPage);
+        store.setField('currentPage', currentPage || 0);
       }}
       {totalPages}
       currentPage={Number($store.currentPage)}

diff --git a/src/state/store.js b/src/state/store.js
@@ -45,7 +45,7 @@ function getDefaultState(
 
   state.aggKey = getFromQueryString('aggKey') || '';
   state.aggType = getFromQueryString('aggType') || 'avg';
-  state.currentPage = getFromQueryString('currentPage') || '1';
+  state.currentPage = getFromQueryString('currentPage');
   state.countView = getFromQueryString('countView') || 'clients';
 
   state.probe = {