Make sure non-normalized data is passed correctly #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iinh
commented
Oct 5, 2023
| }); | ||
| // use transformed data for Android metrics | ||
| if (data[0].transformedPercentiles) { | ||
| if (data[data.length - 1].transformedPercentiles) { |
There was a problem hiding this comment.
we use lengh - 1, instead of 0, because non-normalized data is added later. so the first entry of data array usually doesn't have non-normalized data available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an error detected during pairing yesterday where non-normalized data was not passed down correctly after changing the dropdown option.