Fix #2578 - Distribution Comparison slowness/OOM for non-norm data #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-normalized data
edugfilho
force-pushed
the
fix-non-norm-dist-comp
branch
from
7b97b2a to
711741b
Compare
Iinh
approved these changes
Nov 9, 2023
edugfilho
changed the title
edugfilho
changed the title
edugfilho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know exactly the root cause of the issue, but during my tests I noticed that the slowness/OOM happened whenever the
DistributionComparisonModalcomponent wasn't re-created after changing the normalization type fromClient IdtoNone. So now I'm forcing a re-creation of theDistributionComparisonModalcomponent every time any of the charts (top or bottom chart) data changes.