Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cookie banner #2714

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add cookie banner #2714

merged 3 commits into from
Mar 12, 2024

Conversation

Iinh
Copy link
Contributor

@Iinh Iinh commented Feb 21, 2024

Fixes #2692.

Preview:
CleanShot 2024-02-28 at 13 59 03@2x

@edugfilho
Copy link
Collaborator

The layout looks good to me! I see it's in draft and the actual preferences are not coded in yet. What are next steps to get those?
Also, wasn't there a lib for it? I guess it's not a lot of coding, so maybe not needed.

@Iinh
Copy link
Contributor Author

Iinh commented Feb 22, 2024

The layout looks good to me! I see it's in draft and the actual preferences are not coded in yet. What are next steps to get those?

Thanks! I filled out the request form a while ago and am still waiting for guidance from Marketing/Legal, to decide what the final setting is.

@Iinh Iinh force-pushed the cookie-banner branch 5 times, most recently from 6e320b4 to 018c3ce Compare February 28, 2024 18:58
@Iinh Iinh marked this pull request as ready for review February 28, 2024 19:00
Copy link
Collaborator

@edugfilho edugfilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc
the one bit I would change is that the cookies in this case are not really to enhance the user experience but to analyze our traffic, so I made a suggestion there!

src/components/CookieBanner.svelte Outdated Show resolved Hide resolved
@Iinh Iinh merged commit a411c6e into main Mar 12, 2024
4 checks passed
@Iinh Iinh deleted the cookie-banner branch March 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include cookie banner
2 participants