-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookie banner #2714
Add cookie banner #2714
Conversation
The layout looks good to me! I see it's in draft and the actual preferences are not coded in yet. What are next steps to get those? |
Thanks! I filled out the request form a while ago and am still waiting for guidance from Marketing/Legal, to decide what the final setting is. |
6e320b4
to
018c3ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
the one bit I would change is that the cookies in this case are not really to enhance the user experience but to analyze our traffic, so I made a suggestion there!
Co-authored-by: Eduardo Filho <[email protected]>
Fixes #2692.
Preview:
![CleanShot 2024-02-28 at 13 59 03@2x](https://private-user-images.githubusercontent.com/28797553/308680522-28ecdb23-cbbc-4cdb-9932-eb2274263193.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMzU2MTQsIm5iZiI6MTczOTEzNTMxNCwicGF0aCI6Ii8yODc5NzU1My8zMDg2ODA1MjItMjhlY2RiMjMtY2JiYy00Y2RiLTk5MzItZWIyMjc0MjYzMTkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDIxMDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEzNDQ4MGQ1MjkxODAxYzk0M2VhMjg0OTUyNjdkN2VkZTY4ODUyZjFkNTU0YTcxZmUwYTdlNDkzZjYxZGJiMDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.NAvzGQuq7OBshPHXqst_RlAXqs2lLnRIBohgVv1tdNY)