bug 1925346 - Support new metric type labeled_quantity

mozilla · Oct 21, 2024 · 4586e38 · 4586e38
1 parent 21b1e2d
commit 4586e38
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Bugfix: Remove unused keyword argument from exception ([#755](https://github.com/mozilla/glean_parser/pull/755))
 - Add Go log outputter support for custom pings (`go_server`) ([#758](https://github.com/mozilla/glean_parser/pull/758))
+- New Metric Type: `labeled_quantity` ([bug 1925346](https://bugzilla.mozilla.org/show_bug.cgi?id=1925346))
 
 ## 15.0.1
 

diff --git a/glean_parser/metrics.py b/glean_parser/metrics.py
@@ -425,6 +425,8 @@ class LabeledMemoryDistribution(Labeled, MemoryDistribution):
 class LabeledTimingDistribution(Labeled, TimingDistribution):
     typename = "labeled_timing_distribution"
 
+class LabeledQuantity(Labeled, Quantity):
+    typename = "labeled_quantity"
 
 class Rate(Metric):
     typename = "rate"

diff --git a/glean_parser/schemas/metrics.2-0-0.schema.yaml b/glean_parser/schemas/metrics.2-0-0.schema.yaml
@@ -122,7 +122,7 @@ definitions:
 
                 `labeled_boolean`, `labeled_string`, `labeled_counter`,
                 `labeled_custom_distribution`, `labeled_memory_distribution`,
-                `labeled_timing_distribution`.
+                `labeled_timing_distribution`, `labeled_quantity`.
 
             - `text`: Record long text data.
 
@@ -151,6 +151,7 @@ definitions:
           - labeled_custom_distribution
           - labeled_memory_distribution
           - labeled_timing_distribution
+          - labeled_quantity
           - rate
           - text
           - object

diff --git a/tests/data/all_metrics.yaml b/tests/data/all_metrics.yaml
@@ -148,3 +148,11 @@ all_metrics:
     labels:
       - aLabel
       - 2label
+
+  labeled_quantity:
+    <<: *defaults
+    type: labeled_quantity
+    unit: tabs
+    labels:
+      - aLabel
+      - 2label