Skip to content

Commit

Permalink
Remove now-unused keyword argument
Browse files Browse the repository at this point in the history
When we switched from just printing the error to raising it as an
exception, we accidentally left the `file` argument in.
It's not needed and not accepted by ValueError.
  • Loading branch information
badboy committed Oct 8, 2024
1 parent cf0e3de commit 6a99f4e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Unreleased

- Bugfix: Remove unused keyword argument from exception ([#755](https://github.com/mozilla/glean_parser/pull/755))

## 15.0.1

- Rust codegen: use correctly named parameter for events without extras ([#750](https://github.com/mozilla/glean_parser/pull/750))
Expand Down
2 changes: 0 additions & 2 deletions glean_parser/translate.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from pathlib import Path
import os
import shutil
import sys
import tempfile
from typing import Any, Callable, Dict, Iterable, List, Optional

Expand Down Expand Up @@ -98,7 +97,6 @@ def transform_metrics(objects):
raise ValueError(
f"No `counter` named {denominator_name} found to be used as"
"denominator for {numerators}",
file=sys.stderr,
)
counters[denominator_name].__class__ = metrics.Denominator
counters[denominator_name].type = "denominator"
Expand Down

0 comments on commit 6a99f4e

Please sign in to comment.