Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1906941 - Update kotlin jinja template import statement #740

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

travis79
Copy link
Member

@travis79 travis79 commented Aug 1, 2024

Now that Glean v60.4.0 has released and service-glean android-component has been removed, we can update the Kotlin template to use the glean import of HistogramBase which will allow us to do away with the HistogramMetricBase alias completely.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • make test runs without emitting any warnings
    • make lint runs without emitting any errors
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to language binding APIs are noted explicitly

@travis79 travis79 requested a review from a team as a code owner August 1, 2024 19:13
@travis79 travis79 requested review from chutten and removed request for a team August 1, 2024 19:13
@badboy
Copy link
Member

badboy commented Aug 2, 2024

Note that this is a breaking change and has to go in a major release, to avoid breaking existing code (which auto-updates to minor releases).
Thus this should have a changelog entry.

@travis79
Copy link
Member Author

travis79 commented Aug 2, 2024

Note that this is a breaking change and has to go in a major release, to avoid breaking existing code (which auto-updates to minor releases). Thus this should have a changelog entry.

Is it breaking though if the fix to keep it from breaking is already in place? The breaking part will be removing the alias from glean_core/android ;)

I'll add a changelog entry, regardless. I should have done that anyway :)

@chutten
Copy link
Contributor

chutten commented Aug 2, 2024

I'll add a changelog entry, regardless. I should have done that anyway :)

(and your reviewer should've caught it. Sorry.)

@badboy
Copy link
Member

badboy commented Aug 2, 2024

Note that this is a breaking change and has to go in a major release, to avoid breaking existing code (which auto-updates to minor releases). Thus this should have a changelog entry.

Is it breaking though if the fix to keep it from breaking is already in place? The breaking part will be removing the alias from glean_core/android ;)

Hmmm, I guess right now the same thing is available under both names? If that is so then it might be non-breaking indeed.

Now that Glean v60.4.0 has released and `service-glean` android-component has
been removed, we can update the Kotlin template to use the glean import
of `HistogramBase` which will allow us to do away with the `HistogramMetricBase`
alias completely.
@travis79 travis79 merged commit 55f5e77 into mozilla:main Aug 2, 2024
8 checks passed
@travis79 travis79 deleted the Bug1906941 branch August 2, 2024 16:59
badboy added a commit that referenced this pull request Aug 13, 2024
badboy added a commit that referenced this pull request Aug 13, 2024
badboy added a commit that referenced this pull request Aug 13, 2024
badboy added a commit that referenced this pull request Aug 13, 2024
badboy added a commit that referenced this pull request Aug 14, 2024
badboy added a commit that referenced this pull request Aug 14, 2024
badboy added a commit that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants