-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906941 - Update kotlin jinja template import statement #740
Conversation
Note that this is a breaking change and has to go in a major release, to avoid breaking existing code (which auto-updates to minor releases). |
Is it breaking though if the fix to keep it from breaking is already in place? The breaking part will be removing the alias from glean_core/android ;) I'll add a changelog entry, regardless. I should have done that anyway :) |
(and your reviewer should've caught it. Sorry.) |
Hmmm, I guess right now the same thing is available under both names? If that is so then it might be non-breaking indeed. |
Now that Glean v60.4.0 has released and `service-glean` android-component has been removed, we can update the Kotlin template to use the glean import of `HistogramBase` which will allow us to do away with the `HistogramMetricBase` alias completely.
Now that Glean v60.4.0 has released and
service-glean
android-component has been removed, we can update the Kotlin template to use the glean import ofHistogramBase
which will allow us to do away with theHistogramMetricBase
alias completely.Pull Request checklist
make test
runs without emitting any warningsmake lint
runs without emitting any errorsCHANGELOG.md
or an explanation of why it does not need one