Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M2m topics redirects #6053

Merged
merged 3 commits into from
Jun 12, 2024
Merged

M2m topics redirects #6053

merged 3 commits into from
Jun 12, 2024
+193 −8

Conversation

akatsoulas
Copy link
Collaborator

No description provided.

@akatsoulas akatsoulas marked this pull request as draft June 7, 2024 10:44
This was referenced Jun 7, 2024
Closed
Closed
escattone
escattone reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far @akatsoulas! Some comments below.

kitsune/products/models.py Show resolved Hide resolved
kitsune/products/models.py Outdated Show resolved Hide resolved
kitsune/products/migrations/0008_auto_20240606_2111.py Show resolved Hide resolved
kitsune/products/signals.py Show resolved Hide resolved
kitsune/products/views.py Show resolved Hide resolved
@akatsoulas akatsoulas mentioned this pull request Jun 10, 2024
Closed
@akatsoulas akatsoulas force-pushed the m2m-topics-redirects branch from cb9d376 to acc6fa4 Compare June 10, 2024 12:26
@akatsoulas akatsoulas marked this pull request as ready for review June 10, 2024 12:27
@akatsoulas akatsoulas force-pushed the m2m-topics-redirects branch from acc6fa4 to 4652b56 Compare June 10, 2024 12:43
escattone
escattone reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I'm not sold on is the TopicSlugHistory table.

kitsune/products/models.py Outdated Show resolved Hide resolved
@akatsoulas akatsoulas force-pushed the m2m-topics-redirects branch from 4652b56 to ddb315f Compare June 11, 2024 12:25
escattone
escattone approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

kitsune/products/models.py Show resolved Hide resolved
@akatsoulas akatsoulas merged commit f1bab9f into mozilla:main Jun 12, 2024
2 checks passed
@akatsoulas akatsoulas deleted the m2m-topics-redirects branch June 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escattone escattone escattone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akatsoulas @escattone