Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override the deafult manager #6100

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Do not override the deafult manager #6100

merged 1 commit into from
Jul 4, 2024

Conversation

akatsoulas
Copy link
Collaborator

  • Introduce active manager for Topic and Product

@akatsoulas
Do not override the deafult manager
25b007a 
* Introduce active manager for Topic and Product
@akatsoulas akatsoulas requested a review from escattone July 4, 2024 10:10
@akatsoulas
Copy link
Collaborator Author

This changes back the default manager to models.Manager() and introduces the active manager to solve for the problem that the changelist in the admin interface is missing the archived entries which in turns produces the ID error.

Most of the codebase has been converted to use the active manager. Exceptions to this are the data migrations and all the code responsible to calculate metrics.

I am merging this PR to allow some QA time before Monday and maybe @escattone can have a pass on Monday in case anything is out of place or wrong.

@akatsoulas akatsoulas mentioned this pull request Jul 4, 2024
Closed
@akatsoulas akatsoulas merged commit a7c2b7e into mozilla:main Jul 4, 2024
2 checks passed
@akatsoulas akatsoulas deleted the default-manager branch July 4, 2024 10:31
escattone
escattone reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@escattone escattone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, including the spots where you kept Product.objects instead of changing to Product.active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escattone escattone escattone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akatsoulas @escattone