Improved topic cards now show three articles, with new design #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Alter the help_topics macro to support showing three articles * Add show more section with sectional line above * Add logic to the product_landing view to return docs and counts
smithellis
force-pushed
the
module-topic-list
branch
from
5de6b5b to
6678459
Compare
escattone
reviewed
Dec 18, 2024
escattone
requested changes
Dec 19, 2024
There was a problem hiding this comment.
I think this needs two more adjustments:
- I think the topics card grid should be responsive to screen size, so I think we should collapse to 2 columns or 1 column (depending on the device screen size) in order to avoid the need for horizontal scrolling on mobile and other smaller-screen devices.
- It seems to me that we should delete the
Frequent Topicsheader, which is redundant with theTopicsheader (see image below).
|
@escattone I spoke with Josh and we are in agreement about simplifying the headers. The scrolling is an issue that I think we have a case for elsewhere - not just for this use case but for other cases that use cards. The idea of stacking the cards makes the horizontal scroll too much, but we definitely could improve the other scrolling options. |
escattone
approved these changes
Jan 8, 2025
akatsoulas
reviewed
Jan 9, 2025
smithellis
force-pushed
the
module-topic-list
branch
2 times, most recently
from
02ed05b to
47ea107
Compare
akatsoulas
approved these changes
Jan 15, 2025
escattone
added a commit
that referenced
this pull request
Jan 21, 2025
smithellis
added a commit
to smithellis/kitsune
that referenced
this pull request
Jan 23, 2025
…a#6408) * Improved topic card now show three top articles * Alter the help_topics macro to support showing three articles * Add show more section with sectional line above * Add logic to the product_landing view to return docs and counts * A utility function builds the topics_context for the cards * Fix card scroll for topic cards on mobile
smithellis
added a commit
to smithellis/kitsune
that referenced
this pull request
Jan 23, 2025
…a#6408) * Improved topic card now show three top articles * Alter the help_topics macro to support showing three articles * Add show more section with sectional line above * Add logic to the product_landing view to return docs and counts * A utility function builds the topics_context for the cards * Fix card scroll for topic cards on mobile * Topics can only wrap once before being cut off with ellipses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note - right now this just shows three (the first three) documents in a topic. This should be updated to choose most popular or newest pending discussions with Content.