Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some strings for l10n extraction #6421

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

escattone
Copy link
Contributor

@escattone escattone commented Dec 19, 2024

mozilla/sumo#2103

Notes

This was a quick and easy one. We don't yet support Python f-strings when extracting for localization, so this PR adjusts the 3 f-strings used within gettext calls such that they're included in the extraction process. I ran ./manage.py extract in the context of this PR and verified that each of these strings is now extracted. ✅

@escattone escattone changed the title fix strings for extraction fix strings for l10n extraction Dec 19, 2024
@escattone escattone requested a review from smithellis December 19, 2024 23:45
@escattone escattone changed the title fix strings for l10n extraction fix some strings for l10n extraction Dec 19, 2024
@escattone escattone merged commit f79a387 into mozilla:main Jan 6, 2025
2 checks passed
@escattone escattone deleted the fix-2103 branch January 6, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants