fix: Add unlimitedStorage permission to make sure storage.local does not hit quota limits or IndexedDB QuotaManager data eviction #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'t hit quota limits or IndexedDB QuotaManager data eviction
kendallcorner
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
Extension workshop docs confirm the permission is not "advised" (i.e. it would not be a blocker for update): https://extensionworkshop.com/documentation/develop/request-the-right-permissions/#advised-permissions
Tested the PR, but I did not attempt to replicate the low storage space problem to see if it would fix it!
|
Whoa, thanks! This might help some bug reports we've seen, but been un-able to reproduce, where peoples' Container assignments and settings have been lost and their onboarding state has been reset back to 0. |
|
Thanks @kendallcorner ! Also tested the PR and this looks good. |
groovecoder
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into Bug 1720487 I did notice that multi-account-container isn't currently requesting the "unlimitedStorage" permission.
Without the "unlimitedStorage" permission, multi-account-container may more easily hit a quota limit.
Even besides the quota limit, at the moment the QuotaManager data eviction logic does not special case the extension origins and so there is a chance that below certain free disk space threshold the QuotaManager may select an extension origin while looking for the "least used origins to evict data from" (see Bug 1720487 comment 1 and Bug 1720487 comment 6.
(As a side note, the addition of the "unlimitedStorage" permission does not trigger a permission prompt, as expected for this kind of permission, and so it would not be prompting the user to accept the "unlimitedStorage" permission if included in a new version of the addon, in other words it does not introduce any friction for the existing users).