-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak EventEmitter / chokidar #450
Comments
Seems like invalid usage of chokidar. Line 40 in f92a5bd
this should be changed to |
@paulmillr Thanks for the input. Line L40 loops all paths and pass them to L42 -> Lets see what other guys say here about nunjuck usage because i'm not much familiar with it. |
Thanks for the report. Are you sure you are watching multiple paths? I wasn't aware you could pass multiple paths into chokidar, we should fix that. |
I'm using nunjucks on "views". My "views" folder contains .html files and also another folder called "admin" with more .html inside. |
@felixsanz it should recursively watch all of that. I was asking if you were specifically passing multiple root paths to nunjucks. Still, I'm going to fix the chokidar API call, and maybe that will help. |
* master: (30 commits) Consolidate changelog. Catch correctly error from loaders Add multiline multi block raw test Fix "broken raw blocks test" by strictly searching for raw or endraw blocks only Fix multiple raw blocks with less greedy regex Add test for multiple raw blocks add maintenance note fix links for docs in french add error handler to chokidar instance (fixes mozilla#469) fix jshint error don't break in environment where Error.prototype.name can't be set (fixes mozilla#454) use chokidar correctly (fixes mozilla#450) include bin and src when using bower (fixes mozilla#444) fix version in browserfiles prep for 2.0.0 Docs in french Docs : fix link fix docs: typo parameter caseSens Update web-loaders.js Rewrite Parser.parseRaw ...
Im getting sometimes lot of this errors. I don't usually get them but when i do i get like 10 in the same request. Any idea why this happens? I'm using a wrapper called koajs-nunjucks but the problem is more related to chokidar lib.
The text was updated successfully, but these errors were encountered: