Skip to content

Commit

Permalink
Fix inconsistencies in the preference names used by PDFViewerApplication
Browse files Browse the repository at this point in the history
Since `preferenceSidebarViewOnLoad` is an enumeration value, it seems better to initialize it with the default one instead of a boolean.
`preferencesPdfBugEnabled` uses a superfluous "s", which is a typo I made when I introduced it.
  • Loading branch information
Snuffleupagus committed Oct 1, 2014
1 parent 29eb147 commit a429e88
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions web/viewer.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ var PDFViewerApplication = {
animationStartedPromise: null,
mouseScrollTimeStamp: 0,
mouseScrollDelta: 0,
preferenceSidebarViewOnLoad: false,
preferencesPdfBugEnabled: false,
preferenceSidebarViewOnLoad: SidebarView.NONE,
preferencePdfBugEnabled: false,
isViewerEmbedded: (window.parent !== window),
url: '',

Expand Down Expand Up @@ -222,7 +222,7 @@ var PDFViewerApplication = {
self.preferenceSidebarViewOnLoad = value;
}),
Preferences.get('pdfBugEnabled').then(function resolved(value) {
self.preferencesPdfBugEnabled = value;
self.preferencePdfBugEnabled = value;
}),
Preferences.get('disableTextLayer').then(function resolved(value) {
if (PDFJS.disableTextLayer === true) {
Expand Down Expand Up @@ -1485,7 +1485,7 @@ function webViewerInitialized() {
//#if !PRODUCTION
if (true) {
//#else
//if (PDFViewerApplication.preferencesPdfBugEnabled) {
//if (PDFViewerApplication.preferencePdfBugEnabled) {
//#endif
// Special debugging flags in the hash section of the URL.
var hash = document.location.hash.substring(1);
Expand Down

0 comments on commit a429e88

Please sign in to comment.