Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stray annotations #4914

Closed
automatedbugreportingfacility opened this issue Jun 10, 2014 · 1 comment · Fixed by #4915
Closed

Stray annotations #4914

automatedbugreportingfacility opened this issue Jun 10, 2014 · 1 comment · Fixed by #4915

Comments

@automatedbugreportingfacility

This is a regression. Stray annotations are displayed outside the document bounds. Neither Chrome PDF Viewer nor SumatraPDF shows them.

URL: http://www.rurdev.usda.gov/supportdocuments/rd1924-0005_930800V01.pdf
1.0.326: http://i.imgur.com/orHuP6O.png
0.8.990: http://i.imgur.com/sPSkYGs.png

076b343 is the first bad commit
commit 076b343
Author: Samuel Chantaraud
Date: Fri Mar 7 10:48:42 2014 -0400

Improved annotations' display/behavior.

Added an "InteractiveAnnotation" class to homogenize the annotations' structure (highlighting) and user interactions (for now, used for text and link annotations).

Text annotations:
The appearance (AP) has priority over the icon (Name).
The popup extends horizontally (up to a limit) as well as vertically.
Reduced the title's font size.
The annotation's color (C) is used to color the popup's background.
On top of the mouseover show/hide behavior, a click on the icon will lock the annotation open (for mobile purposes). It can be closed with another click on either the icon or the popup.

An annotation printing is conditioned by its "print" bit
Unsupported annotations are not displayed at all.
@Snuffleupagus
Copy link
Collaborator

/cc @dferer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants