[api-minor] Remove the WebGL implementation #13358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ef4a17b50f3c81d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5a0834d707c0085/output.txt |
Reasons for the removal include: - This functionality was always somewhat experimental and has never been enabled by default, partly because of worries about rendering bugs caused by e.g. bad/outdated graphics drivers. - After the initial implementation, in PR 4286 (back in 2014), no additional functionality has been added to the WebGL implementation. - The vast majority of all documents do not benefit from WebGL rendering, since only a couple of *specific* features are supported (e.g. some Soft Masks and Patterns). - There is, and has always been, *zero* test-coverage for the WebGL implementation. - Overall performance, in the PDF.js library, has improved since the experimental WebGL implementation was added. Rather than shipping unused *and* untested code, it seems reasonable to simply remove the WebGL implementation for now; thanks to version control it's always possible to bring back the code should the need ever arise.
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ef4a17b50f3c81d/output.txt Total script time: 25.94 mins
Image differences available at: http://54.67.70.0:8877/ef4a17b50f3c81d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/5a0834d707c0085/output.txt Total script time: 28.74 mins
Image differences available at: http://3.101.106.178:8877/5a0834d707c0085/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
May 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for the removal include:
This functionality was always somewhat experimental and has never been enabled by default, partly because of worries about rendering bugs caused by e.g. bad/outdated graphics drivers.
After the initial implementation, in PR WebGL and misc memory optimizations #4286 (back in 2014), no additional functionality has been added to the WebGL implementation.
The vast majority of all documents do not benefit from WebGL rendering, since only a couple of specific features are supported (e.g. some Soft Masks and Patterns).
There is, and has always been, zero test-coverage for the WebGL implementation.
Overall performance, in the PDF.js library, has improved since the experimental WebGL implementation was added.
Rather than shipping unused and untested code, it seems reasonable to simply remove the WebGL implementation for now; thanks to version control it's always possible to bring back the code should the need ever arise.
Fixes #5161
Edit: A new version was pushed to fix typos in the commit message, no actual code changes were made.