Fix a couple of old review comments #15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PR 5366 follow-up) Because of a capitalization error, the MIME type wasn't actually being set correctly. However, please note that downloading of font files still worked correctly which is probably why this has gone unnoticed since 2014.
Because of a small oversight, this method accidentally handled the intermediate array incorrectly.
…tAnnotation`-class (PR 14720 follow-up) In the "no fontSize available" code-path, in the `ChoiceWidgetAnnotation._getAppearance` method, we don't provide the necessary second argument when calling the `_getTextWidth`-method which will cause errors to be thrown.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/415e3a6f4ebace5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/714af111bced512/output.txt |
Snuffleupagus
changed the title
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/415e3a6f4ebace5/output.txt Total script time: 26.25 mins
Image differences available at: http://54.241.84.105:8877/415e3a6f4ebace5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/714af111bced512/output.txt Total script time: 28.05 mins
Image differences available at: http://54.193.163.58:8877/714af111bced512/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the comments were made on old, and closed, PRs it's mostly luck that I happened to notice them.
This PR fixes the following comments, with most of them having been introduced earlier (see the individual commit messages):
URL.createObjectURLmethod inweb/debugger.js#11545 (review)pdf.scripting.js/pdf.sandbox.jsfiles from accidentally including most of the main-thread code (PR 12631 follow-up) #12693 (review)