Extend TextLayerRenderParameters.container type to include HTMLElement. #15015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
requested changes
Jun 10, 2022
In PR #14717, the type was changed from a HTMLElement to a DocumentFragment. This broke TypeScript projects that use a HTMLElement container. To remedy this, we extend the type of container to also include HTMLElement.
jerry1100
changed the title
TextLayerRenderParameters.container type from DocumentFragment to NodeTextLayerRenderParameters.container type to include HTMLElement.
jerry1100
changed the title
TextLayerRenderParameters.container type to include HTMLElement.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e4cae86df5e0cd2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e4cae86df5e0cd2/output.txt Total script time: 2.58 mins Published |
Snuffleupagus
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #14717,
TextLayerRenderParameters.containerwas changed from aHTMLElementto aDocumentFragmentsince the prebuilt web viewer uses a fragment.This type breaks projects that use a
HTMLElementfor a container.To remedy this, we extend the type of container to also include
HTMLElement.