Simplify setting the defaultUrl-option in the CHROME viewer (PR 12470 follow-up)
#15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/14f645ac1d79ac5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/14f645ac1d79ac5/output.txt Total script time: 2.56 mins Published |
…70 follow-up) This should really have been done as part of PR 12470, since it's now possible to directly set the `defaultUrl`-option without having to fallback to `var`-usage.
This option is not used, nor has it ever been used, in the *built-in* Firefox PDF Viewer. Hence we can define it only for the environments where it makes sense instead.
Snuffleupagus
force-pushed
the
mv-defaultUrl-option
branch
from
64b4ec0 to
77aa86e
Compare
Snuffleupagus
changed the title
defaultUrl-option in the CHROME viewer (PR 12470 follow-up)defaultUrl-option in the CHROME viewer (PR 12470 follow-up)
timvandermeij
approved these changes
Jun 18, 2022
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should really have been done as part of PR #12470, since it's now possible to directly set the
defaultUrl-option without having to fallback tovar-usage.