Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popup trigger area must filled its parent (fix #15063) #15065

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Popup trigger area must filled its parent (fix #15063) #15065

merged 1 commit into from
Jun 20, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from Snuffleupagus June 19, 2022 20:45
@calixteman calixteman linked an issue Jun 19, 2022 that may be closed by this pull request
Some PopupAnnotation trigger-areas are too small after PR 15036 #15063
Closed
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e7835acec15e4fa/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e7835acec15e4fa/output.txt

Total script time: 2.57 mins

Published

Snuffleupagus
Snuffleupagus approved these changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work just fine, thank you!

@Snuffleupagus Snuffleupagus merged commit ef6142a into mozilla:master Jun 20, 2022
@calixteman
Copy link
Contributor Author

We need to makeref because the position of the popup depends on the area size I guess.
/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/765dba0eb43a9d1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f23e003f23e0f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1f23e003f23e0f8/output.txt

Total script time: 22.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/765dba0eb43a9d1/output.txt

Total script time: 23.05 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Jul 4, 2022
Merged
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
@earthywh earthywh mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some PopupAnnotation trigger-areas are too small after PR 15036
3 participants
@calixteman @Snuffleupagus @pdfjsbot