Add an outline around popup trigger areas in ref-tests #15071

calixteman · 2022-06-20T08:21:46Z

The goal is to avoid any future regressions.

Snuffleupagus · 2022-06-20T08:34:15Z

/botio browsertest

pdfjsbot · 2022-06-20T08:34:17Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/209c02d9ea8e7f7/output.txt

pdfjsbot · 2022-06-20T08:34:17Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/633f390031eab96/output.txt

pdfjsbot · 2022-06-20T08:55:46Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/633f390031eab96/output.txt

Total script time: 21.48 mins

Regression tests: FAILED

  different ref/snapshot: 7

Image differences available at: http://54.193.163.58:8877/633f390031eab96/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-06-20T08:55:59Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/209c02d9ea8e7f7/output.txt

Total script time: 21.70 mins

Regression tests: FAILED

  different ref/snapshot: 30

Image differences available at: http://54.241.84.105:8877/209c02d9ea8e7f7/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2022-06-20T09:28:21Z

test/annotation_layer_builder_overrides.css

@@ -48,3 +47,7 @@
  margin: 0;
  padding: 0;
 }
+
+.annotationLayer .popupTriggerArea {
+  outline: dashed 3px rgba(255, 0, 0, 0.2);


Looking at the test-results, this looks quite similar to annotations with dashed borders.

Hence my question: Should we perhaps use the same kind of styling as for linkAnnotations (above in this file) instead here?

- The goal is to avoid any future regressions.

calixteman · 2022-06-20T19:23:49Z

/botio browsertest

pdfjsbot · 2022-06-20T19:23:50Z

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7c73b9c16786e9e/output.txt

pdfjsbot · 2022-06-20T19:23:50Z

From: Bot.io (Windows)

Received

Command cmd_browsertest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0c6cf845ba87ded/output.txt

pdfjsbot · 2022-06-20T19:45:28Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/0c6cf845ba87ded/output.txt

Total script time: 21.61 mins

Regression tests: FAILED

  different ref/snapshot: 6

Image differences available at: http://54.193.163.58:8877/0c6cf845ba87ded/reftest-analyzer.html#web=eq.log

pdfjsbot · 2022-06-20T19:45:49Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7c73b9c16786e9e/output.txt

Total script time: 21.97 mins

Regression tests: FAILED

  different ref/snapshot: 33

Image differences available at: http://54.241.84.105:8877/7c73b9c16786e9e/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2022-06-20T20:28:48Z

/botio makeref

pdfjsbot · 2022-06-20T22:08:30Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/093837e5487ed80/output.txt

pdfjsbot · 2022-06-20T22:11:03Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6a751bf89adb679/output.txt

pdfjsbot · 2022-06-20T22:31:12Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/093837e5487ed80/output.txt

Total script time: 22.66 mins

Lint: Passed
Make references: Passed
Check references: Passed

pdfjsbot · 2022-06-20T22:33:19Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/6a751bf89adb679/output.txt

Total script time: 22.25 mins

Lint: Passed
Make references: Passed
Check references: Passed

Snuffleupagus · 2022-06-21T09:34:42Z

@calixteman It seems that makeref failed on the Linux bot, since it ran out of storage space.

Some eq tests failed or didn't have snapshots.
Checking to see if master references can be updated...
  Yes!  The references in tmp/ can be synced with ref/.
  Updating ref/ ... 
(node:27868) UnhandledPromiseRejectionWarning: Error: ENOSPC: no space left on device, write
    at Object.writeSync (fs.js:733:3)
    at Object.writeFileSync (fs.js:1530:26)
    at /home/ubuntu/pdfjs/botio-files-pdfjs/private/093837e5487ed80/test/testutils.js:42:10
    at Array.forEach (<anonymous>)
    at copySubtreeSync (/home/ubuntu/pdfjs/botio-files-pdfjs/private/093837e5487ed80/test/testutils.js:35:9)
    at /home/ubuntu/pdfjs/botio-files-pdfjs/private/093837e5487ed80/test/testutils.js:40:7
    at Array.forEach (<anonymous>)
    at copySubtreeSync (/home/ubuntu/pdfjs/botio-files-pdfjs/private/093837e5487ed80/test/testutils.js:35:9)
    at /home/ubuntu/pdfjs/botio-files-pdfjs/private/093837e5487ed80/test/testutils.js:40:7
    at Array.forEach (<anonymous>)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:27868) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:27868) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
[22:31:09] Finished 'runBotMakeref' after 20 min
[22:31:09] Finished 'botmakeref' after 20 min
!botio_message:+ **Make references:** Passed
!botio_message:+ **Check references:** Passed

>> Updating ref snapshots
shell.js: internal error
Error: ENOSPC: no space left on device, write
    at Object.writeSync (fs.js:733:3)
    at copyFileSync (/home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:1065:8)
    at cpdirSyncRecursive (/home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:1109:9)
    at cpdirSyncRecursive (/home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:1100:7)
    at cpdirSyncRecursive (/home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:1100:7)
    at /home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:293:9
    at Array.forEach (<anonymous>)
    at _cp (/home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:270:11)
    at /home/ubuntu/pdfjs/botio-files-pdfjs/node_modules/shelljs/shell.js:1019:23
    at /home/ubuntu/pdfjs/botio-files-pdfjs/on_cmd_makeref.js:76:5

calixteman · 2022-06-21T10:01:46Z

/botio-linux makeref

pdfjsbot · 2022-06-21T10:01:48Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/01c5d00f9f8d1ef/output.txt

pdfjsbot · 2022-06-21T10:24:35Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/01c5d00f9f8d1ef/output.txt

Total script time: 22.76 mins

Lint: Passed
Make references: Passed
Check references: Passed

calixteman requested a review from Snuffleupagus June 20, 2022 08:21

calixteman added the test label Jun 20, 2022

Snuffleupagus reviewed Jun 20, 2022

View reviewed changes

Add an outline around popup trigger areas in ref-tests

fd209d9

- The goal is to avoid any future regressions.

calixteman force-pushed the popup_area_test branch from e13a04e to fd209d9 Compare June 20, 2022 19:23

Snuffleupagus merged commit b00641d into mozilla:master Jun 20, 2022

ZeroXClem mentioned this pull request Aug 12, 2024

[Snyk] Upgrade pdfjs-dist from 2.9.359 to 2.16.105 ZeroXClem/metamesa#3

Closed

earthywh mentioned this pull request Sep 24, 2024

[Snyk] Upgrade pdfjs-dist from 2.6.347 to 2.16.105 earthywh/filestash#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add an outline around popup trigger areas in ref-tests #15071

Add an outline around popup trigger areas in ref-tests #15071

calixteman commented Jun 20, 2022

Snuffleupagus commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

Snuffleupagus Jun 20, 2022

calixteman commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

Snuffleupagus commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

Snuffleupagus commented Jun 21, 2022 •

edited

Loading

calixteman commented Jun 21, 2022

pdfjsbot commented Jun 21, 2022

pdfjsbot commented Jun 21, 2022

Add an outline around popup trigger areas in ref-tests #15071

Add an outline around popup trigger areas in ref-tests #15071

Conversation

calixteman commented Jun 20, 2022

Snuffleupagus commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Failed

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Failed

Snuffleupagus Jun 20, 2022

Choose a reason for hiding this comment

calixteman commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Failed

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Failed

Snuffleupagus commented Jun 20, 2022

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Received

pdfjsbot commented Jun 20, 2022

From: Bot.io (Linux m4)

Failed

pdfjsbot commented Jun 20, 2022

From: Bot.io (Windows)

Success

Snuffleupagus commented Jun 21, 2022 • edited Loading

calixteman commented Jun 21, 2022

pdfjsbot commented Jun 21, 2022

From: Bot.io (Linux m4)

Received

pdfjsbot commented Jun 21, 2022

From: Bot.io (Linux m4)

Success

Snuffleupagus commented Jun 21, 2022 •

edited

Loading