-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Add the possibility to change line opacity in Ink editor #15219
Conversation
fa85bb8
to
6b5a8cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the comments addressed; thank you!
src/core/annotation.js
Outdated
const resources = new Dict(xref); | ||
const extGState = new Dict(xref); | ||
const r0 = new Dict(xref); | ||
r0.set("AIS", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this property actually necessary here?
The reason that I ask is that in the PDF.js library we don't actually support that property, and there's even an old issue related to it (see #6967). Hence it seems slightly strange, at least to me, that we're generating data that we're actually not able to parse/use ourselves.
src/shared/util.js
Outdated
FREETEXT_OPACITY: 2, | ||
INK_COLOR: 3, | ||
INK_THICKNESS: 4, | ||
INK_OPACITY: 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that editing still is in development, and not officially released, this isn't an issue now; however it may become one in the future.
To avoid issues, let's group them like this instead to leave room for future additions without requiring backwards-incompatible changes. (Here I'm assuming that 10
parameters for each Annotation-type is plenty.)
FREETEXT_OPACITY: 2, | |
INK_COLOR: 3, | |
INK_THICKNESS: 4, | |
INK_OPACITY: 5, | |
FREETEXT_SIZE: 1, | |
FREETEXT_COLOR: 2, | |
FREETEXT_OPACITY: 3, | |
INK_COLOR: 11, | |
INK_THICKNESS: 12, | |
INK_OPACITY: 13, |
6b5a8cb
to
f7af776
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b5aaec1e084a3d8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0befa990a994e2c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b5aaec1e084a3d8/output.txt Total script time: 4.65 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0befa990a994e2c/output.txt Total script time: 6.75 mins
|
f7af776
to
29b5bd5
Compare
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/299b070ac5d6ba2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/299b070ac5d6ba2/output.txt Total script time: 4.60 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/00f799e29db431f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/558020e583fc06e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/00f799e29db431f/output.txt Total script time: 5.00 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/558020e583fc06e/output.txt Total script time: 7.38 mins
|
29b5bd5
to
7831a10
Compare
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a6a11ede45dc4bd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/20137b9708ac38c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a6a11ede45dc4bd/output.txt Total script time: 4.73 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/20137b9708ac38c/output.txt Total script time: 7.04 mins
|
No description provided.