Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Update the minimum supported Safari version #15253

Merged
merged 1 commit into from
Jul 31, 2022
Merged

[api-minor] Update the minimum supported Safari version #15253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const AUTOPREFIXER_CONFIG = {
"last 2 versions",
"Chrome >= 76",
"Firefox ESR",
"Safari >= 13",
"Safari >= 13.1",
"> 1%",
"not IE > 0",
"not dead",
Expand Down
7 changes: 0 additions & 7 deletions web/app_options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,6 @@ if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
compatibilityParams.maxCanvasPixels = 5242880;
}
})();

// Support: Safari<13.1
(function checkResizeObserver() {
if (typeof ResizeObserver === "undefined") {
compatibilityParams.annotationEditorMode = -1;
}
})();
}

const OptionKind = {
Expand Down
6 changes: 1 addition & 5 deletions web/base_viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ import {
} from "./ui_utils.js";
import { AnnotationEditorLayerBuilder } from "./annotation_editor_layer_builder.js";
import { AnnotationLayerBuilder } from "./annotation_layer_builder.js";
import { compatibilityParams } from "./app_options.js";
import { NullL10n } from "./l10n_utils.js";
import { PDFPageView } from "./pdf_page_view.js";
import { PDFRenderingQueue } from "./pdf_rendering_queue.js";
Expand All @@ -86,9 +85,6 @@ const PagesCountLimit = {
PAUSE_EAGER_PAGE_INIT: 250,
};

const ANNOTATION_EDITOR_MODE =
compatibilityParams.annotationEditorMode ?? AnnotationEditorType.DISABLE;

function isValidAnnotationEditorMode(mode) {
return (
Object.values(AnnotationEditorType).includes(mode) &&
Expand Down Expand Up @@ -281,7 +277,7 @@ class BaseViewer {
this.#annotationMode =
options.annotationMode ?? AnnotationMode.ENABLE_FORMS;
this.#annotationEditorMode =
options.annotationEditorMode ?? ANNOTATION_EDITOR_MODE;
options.annotationEditorMode ?? AnnotationEditorType.DISABLE;
this.imageResourcesPath = options.imageResourcesPath || "";
this.enablePrintAutoRotate = options.enablePrintAutoRotate || false;
if (
Expand Down