[GENERIC viewer] Export some viewer constants in the default viewer (issue 15294) #15300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the existing `LinkTarget` constant, used by the `PDFLinkService`-constructor, this patch exports the following constants in the viewer components: - `ScrollMode` and `SpreadMode`, since the `BaseViewer` has getters/setters which work with those constants. - `RenderingStates`, since that one may be helpful when using `PDFPageView` directly.
…issue 15294) This exports the same constants as the viewer components, but in the default viewer. To avoid bloating the global-scope the constants are added to a new `PDFViewerApplicationConstants` object[1], which also allows us to skip this in builds where it's not actually needed (e.g. the Firefox *built-in* PDF Viewer). *Please note:* I'm not completely sold on this idea, and thus wouldn't mind the patch being rejected, since we probably don't want to export every single viewer constant this way. (And it may seem a bit arbitrary, to users, why some constants are exported and others are not.) --- [1] Somewhat similar to the existing `PDFViewerApplicationOptions` structure.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0aeaca5d7c58f6d/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0be0d5a278a8526/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0be0d5a278a8526/output.txt Total script time: 4.86 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0aeaca5d7c58f6d/output.txt Total script time: 8.81 mins
|
timvandermeij
approved these changes
Aug 13, 2022
|
I can see a use case for this, so let's do it. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the same constants as the viewer components, but in the default viewer. To avoid bloating the global-scope the constants are added to a new
PDFViewerApplicationConstantsobject[1], which also allows us to skip this in builds where it's not actually needed (e.g. the Firefox built-in PDF Viewer).Please note: I'm not completely sold on this idea, and thus wouldn't mind the patch being rejected, since we probably don't want to export every single viewer constant this way. (And it may seem a bit arbitrary, to users, why some constants are exported and others are not.)
[1] Somewhat similar to the existing
PDFViewerApplicationOptionsstructure.