Don't add aria-owns attributes for non-existent elements (PR 15237 follow-up)
#15311
Conversation
…follow-up) Currently when the `TextAccessibilityManager.enabled` method is called, we'll update `aria-owns` for any pre-existing elements. This obviously makes sense when e.g. zooming/rotating in the viewer, since the annotationLayer/annotationEditorLayer is kept in those cases. However when the page is *fully* reset, e.g. as result of going out-of-view and thus being evicted from the cache, we still keep the `#textNodes`-Map around. This causes us to set the `aria-owns` attribute (in the textLayer) for an element that doesn't actually exist any more, which as far as I'm concerned seems incorrect. In this case the element will simply, as already implemented, be re-inserted when the annotationLayer/annotationEditorLayer renders again.
Snuffleupagus
force-pushed
the
text-a11y-removed-element
branch
from
8378c35 to
6c4561f
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/10c5a97c00aa6fe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5e39b68e4532f6a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/10c5a97c00aa6fe/output.txt Total script time: 4.91 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5e39b68e4532f6a/output.txt Total script time: 6.47 mins
|
|
Do you think I should make a new release ? |
You mean update the version in Firefox? (Since the next release of the general PDF.js library isn't due just yet :-)
Enjoy your time off! |
Currently when the
TextAccessibilityManager.enabledmethod is called, we'll updatearia-ownsfor any pre-existing elements. This obviously makes sense when e.g. zooming/rotating in the viewer, since the annotationLayer/annotationEditorLayer is kept in those cases.However when the page is fully reset, e.g. as result of going out-of-view and thus being evicted from the cache, we still keep the
#textNodes-Map around. This causes us to set thearia-ownsattribute (in the textLayer) for an element that doesn't actually exist any more, which as far as I'm concerned seems incorrect. In this case the element will simply, as already implemented, be re-inserted when the annotationLayer/annotationEditorLayer renders again.