-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JS] Run the named actions before running the format when the file is open (issue #15818) #15822
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the comment addressed; thank you!
… open (issue mozilla#15818) It's a follow-up of mozilla#14950: some format actions are ran when the document is open but we must be sure we've everything ready for that, hence we have to run some named actions before runnig the global format. In playing with the form, I discovered that the blur event wasn't triggered when JS called `setFocus` (because in such a case the mouse was never down). So I removed the mouseState thing to just use the correct commitKey when blur is triggered by a TAB key.
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e814e934fab36c1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/85c8a486c856116/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/85c8a486c856116/output.txt Total script time: 4.29 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e814e934fab36c1/output.txt Total script time: 10.27 mins
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ddff35a0e96993a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/42d85734d903ed9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/42d85734d903ed9/output.txt Total script time: 2.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/ddff35a0e96993a/output.txt Total script time: 7.93 mins
|
else auto-print is broken (it's a regression from patch mozilla#15822).
else auto-print is broken (it's a regression from patch mozilla#15822).
else auto-print is broken (it's a regression from patch mozilla#15822).
It's a follow-up of #14950: some format actions are ran when the document is open but we must be sure we've everything ready for that, hence we have to run some named actions before runnig the global format.
In playing with the form, I discovered that the blur event wasn't triggered when JS called
setFocus
(because in such a case the mouse was never down). So I removed the mouseState thing to just use the correct commitKey when blur is triggered by a TAB key.