Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Run the named actions before running the format when the file is open (issue #15818) #15822

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

calixteman
Copy link
Contributor

It's a follow-up of #14950: some format actions are ran when the document is open but we must be sure we've everything ready for that, hence we have to run some named actions before runnig the global format.
In playing with the form, I discovered that the blur event wasn't triggered when JS called setFocus (because in such a case the mouse was never down). So I removed the mouseState thing to just use the correct commitKey when blur is triggered by a TAB key.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed; thank you!

src/display/annotation_layer.js Show resolved Hide resolved
… open (issue mozilla#15818)

It's a follow-up of mozilla#14950: some format actions are ran when the document is open
but we must be sure we've everything ready for that, hence we have to run some
named actions before runnig the global format.
In playing with the form, I discovered that the blur event wasn't triggered when
JS called `setFocus` (because in such a case the mouse was never down). So I removed
the mouseState thing to just use the correct commitKey when blur is triggered by a
TAB key.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e814e934fab36c1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/85c8a486c856116/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/85c8a486c856116/output.txt

Total script time: 4.29 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e814e934fab36c1/output.txt

Total script time: 10.27 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ddff35a0e96993a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_unittest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/42d85734d903ed9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/42d85734d903ed9/output.txt

Total script time: 2.35 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/ddff35a0e96993a/output.txt

Total script time: 7.93 mins

  • Unit Tests: Passed

@calixteman calixteman merged commit e182597 into mozilla:master Dec 13, 2022
@calixteman calixteman deleted the 15818 branch December 13, 2022 20:56
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 4, 2023
else auto-print is broken (it's a regression from patch mozilla#15822).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 4, 2023
else auto-print is broken (it's a regression from patch mozilla#15822).
calixteman added a commit to calixteman/pdf.js that referenced this pull request Jan 4, 2023
else auto-print is broken (it's a regression from patch mozilla#15822).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't edit some fields in the DB (Deutsche Bahn) reimbursment form
3 participants