Always enable smoothing when rendering downscaled image #17868
Conversation
|
Thanks for this, looks like it improves the PDF quality in Firefox as well :) After: |
There was a problem hiding this comment.
Looks good! Is there perhaps a reference to an issue (either on GitHub or Bugzilla), or does it not exist (yet)? If this improves a particular PDF file, would it be possible to add a reference test for this improvement so we avoid regressing it in the future or is it already covered by the existing reference tests?
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5f73ea89661b0f7/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7f9e2fca1a5f7af/output.txt |
|
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7f9e2fca1a5f7af/output.txt Total script time: 26.23 mins
Image differences available at: http://54.241.84.105:8877/7f9e2fca1a5f7af/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5f73ea89661b0f7/output.txt Total script time: 42.92 mins
Image differences available at: http://54.193.163.58:8877/5f73ea89661b0f7/reftest-analyzer.html#web=eq.log |
calixteman
force-pushed
the
interpolate_flag
branch
from
1558a40 to
45b15aa
Compare
|
/botio browsertest |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/78e3c81b81dcbab/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d434381c52606ed/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d434381c52606ed/output.txt Total script time: 18.25 mins
Image differences available at: http://54.241.84.105:8877/d434381c52606ed/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/78e3c81b81dcbab/output.txt Total script time: 27.10 mins
Image differences available at: http://54.193.163.58:8877/78e3c81b81dcbab/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
I think this change is correct, with the two questions answered/addressed, and overall this seems like a good rendering improvement to me. It would be good though if @Snuffleupagus also signed off on this before merging, to make sure I didn't miss anything since this logic is important for rendering and it seems a bit tricky looking at how the spec describes it and how other viewers implement it.
There was a problem hiding this comment.
Looks good to me, with the remaining comment above addressed (and the tests re-run if the change is made) and a check from @Snuffleupagus. Thank you for improving this!
|
@Snuffleupagus, gentle ping ? |
Sorry, last I looked at this there were still "open" review questions and then it slipped my mind (since I'm still short on time for open source stuff). |
and rely on the Interpolate flag only when the image is upscaled. Fixes mozilla#16273.
calixteman
force-pushed
the
interpolate_flag
branch
from
45b15aa to
b511878
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1b259618dc2ab93/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/1ce3caf39edd715/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1b259618dc2ab93/output.txt Total script time: 27.18 mins
Image differences available at: http://54.241.84.105:8877/1b259618dc2ab93/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1ce3caf39edd715/output.txt Total script time: 43.04 mins
Image differences available at: http://54.193.163.58:8877/1ce3caf39edd715/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b13a432d5316a70/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4233a562b108213/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b13a432d5316a70/output.txt Total script time: 19.41 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4233a562b108213/output.txt Total script time: 24.95 mins
|
and rely on the Interpolate flag only when the image is upscaled.
Fixes #16273.